Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LTK Refactoring when copying (duplicating) a Project. #2262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

N1k145
Copy link
Contributor

@N1k145 N1k145 commented Sep 12, 2024

The Idea is that currently it is not possible to modify a project when it is copied and renamed. This leads to usability issues for example in PDE, where the rename of a project modifies the MANIFEST.MF but a copy does not. This solves this by providing a copy project refactoring that can be extended using a copy participant.

This is related to #2155
This is not done jet, but it would be great if somebody could have a smal look from architecture/concept perspective.
Where I am currently unsure is the using of the CopyParticipants. I have seen there is a MoveRename Refactoring, which is basically a mixture of moving and renaming but that is using RenameParticipants.
Can somebody comment what they think is the correct approach?

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Test Results

  605 files   -   605    605 suites   - 605   37m 14s ⏱️ - 32m 54s
7 700 tests +    1  7 421 ✅  -    44  278 💤 + 45  1 ❌ ±0 
8 087 runs   - 8 085  7 806 ✅  - 7 851  280 💤  - 234  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 4acc07e. ± Comparison against base commit 8df2017.

This pull request skips 45 tests.
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
UiTestSuite org.eclipse.ui.tests.internal.InternalTestSuite org.eclipse.ui.tests.internal.TextHandlerTest ‑ testEditableText
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndPerspective
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndPerspectiveAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePartOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePerspectiveAndWindow
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInActivePerspectiveOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerInWindowOnly
org.eclipse.e4.ui.tests.workbench.HandlerActivationTest ‑ testHandlerSwitchToInactivePart
…

♻️ This comment has been updated with latest results.

@N1k145 N1k145 force-pushed the copyProjectWithLTK-2155 branch 3 times, most recently from 2c0c8eb to f73dc58 Compare September 20, 2024 09:28
The Idea is that currently it is not possible to modify a project when it is copied and renamed. This leads to usability issues for example in PDE, where the rename of a project modifies the MANIFEST.MF but a copy does not.
This solves this by providing a copy project refactoring that can be extended using a copy participant.
@N1k145 N1k145 marked this pull request as ready for review September 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant