Fix org.apache.jasper.glassfish dependency in infocenter.product

[merks]

eclipse-platform/eclipse.platform.releng.aggregator#1251

[merks]

@iloveeclipse

Should we just merge this so we can kick off an I-Build?

[iloveeclipse]

@iloveeclipse

Should we just merge this so we can kick off an I-Build?

Don't we need batch compiler in this product?

[merks]

@iloveeclipse
Should we just merge this so we can kick off an I-Build?

Don't we need batch compiler in this product?

Maybe? Probably? This product is plugin-based not feature-based so maybe that makes a difference?

It looks like this verification build will build the infocenter so we might as well wait for that the build here first...

[iloveeclipse]

In doubt, I would propose to add batch compiler.

[merks]

I think it wouldn't hurt and we already realize that we need it (it's package export) in other places so I tend to agree.

Note that we have other "strange dependencies" that I didn't understand their purpose also related to this theme:

eclipse.platform/ua/org.eclipse.ua.tests/pom.xml

Lines 58 to 69 in e5f0703

	<requirement>
	<type>eclipse-plugin</type>
	<id>org.eclipse.jdt.core.compiler.batch</id>
	<versionRange>0.0.0</versionRange>
	</requirement>
	<requirement>
	<type>eclipse-plugin</type>
	<id>org.mortbay.jasper.apache-jsp</id>
	<versionRange>0.0.0</versionRange>
	</requirement>
	</extraRequirements>
	</dependency-resolution>

[merks]

@iloveeclipse

FYI, it looks like the continuous-integration/jenkins/pr-head build got past building the infocenter-product:

09:03:56.831 [INFO] --- tycho-apitools:4.0.2:verify (verify) @ infocenter-product ---
09:03:56.833 [INFO] 
09:03:56.833 [INFO] ---------< eclipse.platform.ua:org.eclipse.ui.intro.universal >---------

Do you still think it's best to include the batch compiler immediately?

[merks]

Everything appears to have build, but there continue to be test failures that may well be because of missing things but those things might handled previous via the pom dependencies as mentioned here:

#688 (comment)

@iloveeclipse

Please advise at how you would like to proceed... I think/hope that with these changes the I-Build would work, although with test failures...

[iloveeclipse]

Compile time doesn't need "jsp compiler" but at runtime product will miss the compiler package for sure.
Ed, please add batch compiler to the product, merge PR & start I Build.

[iloveeclipse]

Note that we have other "strange dependencies" that I didn't understand their purpose also related to this theme:

No idea. I guess an attempt to make similar change like we do now.

[github-actions]

Test Results

       42 files  ±0         42 suites  ±0   53m 29s ⏱️ + 2m 51s
  3 771 tests ±0    3 762 ✔️ ±0    3 💤 ±0    4 ❌ ±0  2 🔥 ±0 
11 316 runs  ±0  11 271 ✔️ ±0  27 💤 ±0  12 ❌ ±0  6 🔥 ±0 

For more details on these failures and errors, see this check.

Results for commit 4895bca. ± Comparison against base commit e5f0703.

[merks]

Build running:

https://ci.eclipse.org/releng/job/Builds/job/I-build-4.30/15/

[merks]

@iloveeclipse

The build completed.

I assume there are likely to be test failures, though those UA tests are passing for me...