Added widget template with unit tests #112
Conversation
There was a problem hiding this comment.
@JonasHelming I'd be fine with adding the unit-tests directly in the widget template rather than splitting it up into two templates. Any reason we want to do the split?
|
Good question! Only reason would be separation of concerns and keep the plain widget template simpler. So you would prefer to merge them? |
|
Please note, that I will contribute a template for Ui tests as well |
|
@JonasHelming I think merging them where we have the For comparison, I believe extensions generated with |
|
I don't have a strong opinion of using mocha (or another testing framework) vs jest, so I'll leave the decision up to you :) |
fixed #103 Contributed on behalf of STMicroelectronics Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
|
merged! |
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Co-authored-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
There was a problem hiding this comment.
@JonasHelming the changes look good to me, can you please use the squash and merge option when merging so we can have a clean history?
|
Sure, thank you very much for the review, Vince! |
fixed #103
Adds an extended version of the widget template including unit tests.
How to test:
Contributed on behalf of STMicroelectronics
Signed-off-by: Jonas Helming jhelming@eclipsesource.com