Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

org.eclipse.tycho:tycho-versions-plugin:bump-versions does not honor SNAPSHOT suffix #2877

Closed
mlehmannm opened this issue Oct 2, 2023 · 2 comments
Closed

org.eclipse.tycho:tycho-versions-plugin:bump-versions does not honor SNAPSHOT suffix #2877

mlehmannm opened this issue Oct 2, 2023 · 2 comments

Comments

@mlehmannm
Copy link
Contributor

When I use the bump-versions mojo as described here, then the qualifier in the manifest and/or the snapshot suffix in the pom.xml of the bundle that get its version bumped is wiped out.
@laeubi
Copy link
Member

laeubi commented Oct 2, 2023

@mlehmannm we have some integration test for the version plugin here:

https://github.com/eclipse-tycho/tycho/tree/master/tycho-its/src/test/java/org/eclipse/tycho/test/versionsplugin

Can you provide an integration-test to demonstrate the issue?

@mlehmannm
Copy link
Contributor Author

Give me some minutes and I'll provide a fix.

mlehmannm added a commit to mlehmannm/tycho that referenced this issue Oct 2, 2023
@mlehmannm
fix eclipse-tycho#2877
8668914
mlehmannm added a commit to mlehmannm/tycho that referenced this issue Oct 2, 2023
@mlehmannm
Retain .qualifier/-SNAPSHOT on version bump
c610c26 
fix eclipse-tycho#2877
mlehmannm added a commit to mlehmannm/tycho that referenced this issue Oct 2, 2023
@mlehmannm
Retain .qualifier/-SNAPSHOT on version bump
fc8c8df 
fix eclipse-tycho#2877
mlehmannm added a commit to mlehmannm/tycho that referenced this issue Oct 2, 2023
@mlehmannm
Retain .qualifier/-SNAPSHOT on version bump
4b79f17 
fix eclipse-tycho#2877
@laeubi laeubi closed this as completed in 3b42036 Oct 28, 2023
github-actions bot pushed a commit that referenced this issue Oct 28, 2023
@mlehmannm
fix #2877 (#2878)
730d00a 
Retain .qualifier/-SNAPSHOT on version bump

fix #2877

(cherry picked from commit 3b42036)
laeubi pushed a commit that referenced this issue Oct 28, 2023
@mlehmannm @laeubi
fix #2877 (#2878)
f667fd4 
Retain .qualifier/-SNAPSHOT on version bump

fix #2877

(cherry picked from commit 3b42036)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlehmannm @laeubi