ApiAnalysisMojo fails with API error if build.properties has missing 'output.. = bin/' entry

[jukzi]

Without "output.. = bin/" all builds fail

for example
eclipse-platform/eclipse.platform#841
eclipse-platform/eclipse.platform.ui#1286
eclipse-equinox/p2#382

[jukzi]

probably caused by
#2996

[jukzi]

@akurtakov can you please help?

[laeubi]

@jukzi can you please link the documentation that shows that "default"?

I can't find any defaults described here:

https://help.eclipse.org/latest/index.jsp?topic=%2Forg.eclipse.pde.doc.user%2Freference%2Fpde_feature_generating_build.htm

[jukzi]

pde only creates the file and uses JDT to interpret the javaproject output. JDT then adds the default value.

[laeubi]

Correct so there is no default, you could be happy that Tycho is not that strict here and always includes the default folder, because according to the spec a missing output.. = bin/ would mean the bundle should be empty == contain no classes at all.

[jukzi]

In eclipse.jdt.debug\org.eclipse.jdt.debug\build.properties the workaround does not help
There is already a output.jdimodel.jar
Adding a output.. = bin/ would introduce a warning Redundant entry for output folder 'bin/'. It does not correspond to any source folder in 'source..' entry.

[laeubi]

Adding a output.. = bin/ would introduce a warning Redundant entry for output folder 'bin/'. It does not correspond to any source folder in 'source..' entry.

this build configuration is just odd... what it does is putting everything from bin/ into a jdimodel.jar

output.jdimodel.jar = bin/

this jar then is used as the bundle content, if you look at the jar it looks like this:

No idea why one needs jdimodel.jar and can't put it directly in the bundle, searching for jdimodel.jar in java files did not reveal any usage where it might be used (and even if in such case the bundle itself could be used), but as it uses Eclipse-BundleShape: dir it seem to want extract it somehow on the file system (again, no clue why the bundle itself is not suitable here).

But in general it should work, so is there a minimal PR where one can see the problem?

[laeubi]

The problem might be here that multiple source(jar) folders map to the same output folder, will investigate this.

[laeubi]

I think the problem is that if there is no dedicated output folder for the jar Tycho uses the default output folder, that's a bit inconsistent but I'll se if I can even account for this.