Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve probing for GA #169

Merged
merged 7 commits into from
Nov 23, 2022
Merged

feat: improve probing for GA #169

merged 7 commits into from
Nov 23, 2022

Conversation

kkafar
Copy link
Collaborator

@kkafar kkafar commented Nov 23, 2022

Description

Fixed StdoutProbe && added logging backend to example application.

Also I changed all println!(…) calls to info!(…) -- this allows end user to use any desired logging backend.

Linked issues

Resolves #126

Important implementation details

@kkafar kkafar self-assigned this Nov 23, 2022
@kkafar kkafar marked this pull request as ready for review November 23, 2022 16:39
@kkafar kkafar merged commit 961e34b into main Nov 23, 2022
@kkafar kkafar deleted the @kkafar/probing-for-ga branch November 23, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GA] Bring back proper probing
1 participant