Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid conflicting default values & some refactoring #194

Merged
merged 21 commits into from
Nov 26, 2022

Conversation

kkafar
Copy link
Collaborator

@kkafar kkafar commented Nov 26, 2022

Description

This PR:

  • Solves [GA] Time based termination criteria conflicts with generation based one #191 (no more conflicting default GAParams values)
  • Adds ton of assertions & much better error handling to builders
  • Splits presets module into two separate (one module for one builder), but there is no change from end-user perspective - I've just found it tedious & impractical to work with multiple impls in single file
  • Adds tests for builder module
  • Moves responsibility of setting default values to particular builders

Linked issues

Resolves #191
Resolves #192
Resolves #145

@kkafar kkafar self-assigned this Nov 26, 2022
@kkafar kkafar changed the title Rename generation_upper_bound -> generation_limit fix: avoid conflicting default values & some refactoring Nov 26, 2022
@kkafar kkafar marked this pull request as ready for review November 26, 2022 17:03
@kkafar kkafar merged commit eb0d8e4 into main Nov 26, 2022
@kkafar kkafar deleted the @kkafar/fix-stop-criteria branch November 26, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant