Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ordered crossover implementation #196

Merged
merged 5 commits into from
Nov 27, 2022
Merged

Conversation

co012
Copy link
Collaborator

@co012 co012 commented Nov 26, 2022

Linked issues

Closes #47

@co012 co012 self-assigned this Nov 26, 2022
@co012 co012 requested a review from kkafar November 26, 2022 20:42
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really read into logic yet, leaving stylistic notes below.
I'll come back with logic review soon.

src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems ok. Please address my comments and we're ready to ship it.

src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
@kkafar kkafar changed the title feat: Ordered crossover implementation feat: ordered crossover implementation Nov 27, 2022
@co012 co012 merged commit 662e080 into main Nov 27, 2022
@co012 co012 deleted the @co012/ordered-crossover branch November 27, 2022 13:39
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, ship it 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GA] Ordered Crossover operator
2 participants