feat: random permutation population generator #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
I've come to settlement with myself and decided that we can go with this kind of implementation for now (in this stage of the library development). However we should consider providing:
- Much more efficient solution
- Generating permutations only from integers 1, ..., n
| } | ||
| } | ||
|
|
||
| impl<GeneT: Copy + Debug + Sync + Send> PopulationGenerator<Vec<GeneT>> for RandomPermutations<GeneT> { |
There was a problem hiding this comment.
Suggested change
| impl<GeneT: Copy + Debug + Sync + Send> PopulationGenerator<Vec<GeneT>> for RandomPermutations<GeneT> { | |
| impl<GeneT: Copy> PopulationGenerator<Vec<GeneT>> for RandomPermutations<GeneT> { |
Is there a particular reason for these three trait bounds: Debug, Sync, Send?
Particularly the last two should be auto-implemented (you don't need to do it manually AFAIK.
There was a problem hiding this comment.
It didn't work without them.
There was a problem hiding this comment.
Interesting. Could you give more specific info? Only method I see here, that could potentially require it is shuffle, but there are no trait bounds there. Maybe I'm missing something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added random permutation population generator
Linked issues
Closes #148
Important implementation details
Generator doesn't promises uniquids of generated individuals, it is possible to implement but it will generate a lot of overhead