Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PPX crossover operator #208

Merged
merged 9 commits into from
Dec 13, 2022
Merged

feat: PPX crossover operator #208

merged 9 commits into from
Dec 13, 2022

Conversation

co012
Copy link
Collaborator

@co012 co012 commented Dec 4, 2022

Linked issues

Closes #46

@co012 co012 requested a review from kkafar December 4, 2022 17:45
kkafar
kkafar approved these changes Dec 4, 2022
View reviewed changes
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Please consider my suggestions.

src/ga/operators/crossover.rs Show resolved Hide resolved
src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
co012 and others added 2 commits December 5, 2022 12:16
@co012 @kkafar
Apply suggestions from code review
cbfa820 
Co-authored-by: Kacper Kafara <kacperkafara@gmail.com>
@co012
change to random number generation
4ce80b2
kkafar
kkafar requested changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes below.

src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
src/ga/operators/crossover.rs Outdated Show resolved Hide resolved
@kkafar kkafar added this to the Release 0.1.0-beta.1 milestone Dec 7, 2022
@co012 co012 self-assigned this Dec 9, 2022
@co012 co012 requested a review from kkafar December 13, 2022 17:34
kkafar
kkafar approved these changes Dec 13, 2022
View reviewed changes
Copy link
Collaborator

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@co012 co012 merged commit 9ef02e6 into main Dec 13, 2022
@co012 co012 deleted the @co012/ppx-crossover branch December 13, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkafar kkafar kkafar approved these changes

Assignees

@co012 co012

Labels
None yet
Projects
None yet
Milestone
Release 0.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

[GA] PPX crossover operator
2 participants
@co012 @kkafar