feat: change fitness from function to struct #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
approved these changes
Dec 19, 2022
Comment on lines
+1
to
+21
| use crate::ga::individual::Chromosome; | ||
|
|
||
| pub trait Fitness<T: Chromosome> { | ||
| fn apply(&self, chromosome: &T) -> f64; | ||
| } | ||
|
|
||
| pub struct FnBasedFitness<T: Chromosome> { | ||
| fn_ptr: fn(&T) -> f64, | ||
| } | ||
|
|
||
| impl<T: Chromosome> FnBasedFitness<T> { | ||
| pub fn new(fn_ptr: fn(&T) -> f64) -> Self { | ||
| FnBasedFitness { fn_ptr } | ||
| } | ||
| } | ||
|
|
||
| impl<T: Chromosome> Fitness<T> for FnBasedFitness<T> { | ||
| fn apply(&self, chromosome: &T) -> f64 { | ||
| (self.fn_ptr)(chromosome) | ||
| } | ||
| } |
There was a problem hiding this comment.
We should try to avoid usage of pointers here (I know that it was implemented with function pointers before), as we spent a lot of time on making the whole to use static-dispatch only. Calling the most hot function in our system via pointer kinda defeats this purpose. But I guess, we should maybe create separate issue for that.
# Conflicts: # src/ga/builder/bistring.rs # src/ga/builder/realvalued.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
Closes #217