Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FF] Bugfix attempt #292

Merged
merged 6 commits into from
Dec 28, 2022
Merged

[FF] Bugfix attempt #292

merged 6 commits into from
Dec 28, 2022

Conversation

Cinereo2
Copy link
Collaborator

Fix for out-of-bound search in FF

Linked issues

Resolves #289

co012
co012 reviewed Dec 28, 2022
View reviewed changes
src/ff.rs Show resolved Hide resolved
co012
co012 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@co012 co012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work as long as population[index][dimension] + step != NaN

@Cinereo2 Cinereo2 merged commit 35a2020 into main Dec 28, 2022
@Cinereo2 Cinereo2 deleted the ff-bound-bugfix branch December 28, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@co012 co012 co012 approved these changes

@kkafar kkafar Awaiting requested review from kkafar

@Garion9 Garion9 Awaiting requested review from Garion9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FF] Fireflies pass search bound when large number of dimensions is used
2 participants
@Cinereo2 @co012