feat: allow for various types of genes in chromosome #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces parameterized gene type -> it is no longer fixed to
f64. However it is still required that chromosome is of typeVec<GeneT>. I've tried to loose this restriction, but I encountered many problems with types and I eventually gave up (for now -- this is still something we should try to achieve).Moreover this PR introduces
ChromosomeWrapper<GeneT>type which allows user to add custom state to their individuals types.I left some code commented out so that I don't have to refactor whole project each time I make some small type change.
Linked issues
Resolves #33
Important implementation details