fix: implement suggestions from PR#67 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary calls to 'iter()'. Simplified creating return values.
kkafar
approved these changes
Nov 12, 2022
There was a problem hiding this comment.
Good job 🎉
One last thing:
I'm might be wrong, but I believe that we have module test_functions and test_functions::test_functions. This causes some imports to look rather strange. I recommend using new-style modules and flattening the module hierarchy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed usages of 'panic!' to 'assert!' in test functions. Removed unnecessary calls to 'iter()'. Simplified creating return values.