Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sveltekit built in authentication flow due to missing verifier cookie #1105

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

noxan
Copy link
Contributor

@noxan noxan commented Sep 17, 2024

The built in authentication flow with sveltekit is broken due to a missing verifier cookie.

Aligned with nextjs implementation, see https://github.com/edgedb/edgedb-js/blob/b9ddf43bed64eb5a356584396c11244bf854aec6/packages/auth-nextjs/src/shared.ts#L514C48-L514C56

@edgedb-cla
Copy link

edgedb-cla bot commented Sep 17, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Collaborator

@scotttrinh scotttrinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks for the fix!

@scotttrinh scotttrinh enabled auto-merge (squash) September 17, 2024 13:30
@scotttrinh scotttrinh merged commit 386861f into edgedb:master Sep 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants