Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example: filtered delete with in operator #667

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

scotttrinh
Copy link
Collaborator

I was pairing with @DijanaPavlovic on doing this exact thing, and it took us both a few minutes to wrap our heads around this so thought it was worth adding an example to the docs.

Added a test to make sure I didn't screw this up!

@scotttrinh scotttrinh changed the title Add example for in operator with an array Add example: filtered delete with in operator Jun 23, 2023
@diksipav
Copy link
Contributor

Hey, @scotttrinh this is great... I'm just not sure what is the intent in general throughout the docs, there is delete inside QueryBuilder and Delete like a separate page with only one simple example... @raddevon

@scotttrinh
Copy link
Collaborator Author

there is delete inside QueryBuilder and Delete like a separate page with only one simple example...

Yeah, I agree that it's confusing and could be cleaned up a lot. Maybe we move the "cheatsheet" examples into their respective top-level page? Seems like that's easier to reference then going to the bottom of the query builder docs.

Thoughts @raddevon

@raddevon
Copy link
Contributor

@scotttrinh @DijanaPavlovic I like the idea of moving the cheatsheet examples into their respective sections. I think our goal is to ultimately do something like that with all of the top-level cheatsheets (Guides > Cheatsheets) as well, so this would make the JS docs consistent with the rest once that effort is completed.

@scotttrinh scotttrinh merged commit b2d9ef5 into master Jun 28, 2023
7 checks passed
@scotttrinh scotttrinh deleted the docs/delete-in-example branch June 28, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants