Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(security): Mark AddRoute(unauthenticated) as Deprecated #1445

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(security): Mark AddRoute(unauthenticated) as Deprecated #1445

merged 1 commit into from
Jul 19, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Jul 19, 2023

Closes #1437

Additionally adds error checks to unit tests

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    <link to docs PR>

Testing Instructions

"make test"

New Dependency Instructions (If applicable)

Closes #1437

Additionally adds error checks to unit tests

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #1445 (2327eac) into main (10a2ee8) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1445   +/-   ##
=======================================
  Coverage   66.83%   66.83%           
=======================================
  Files          36       36           
  Lines        3088     3088           
=======================================
  Hits         2064     2064           
  Misses        891      891           
  Partials      133      133           

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit e4cd9f7 into edgexfoundry:main Jul 19, 2023
1 check passed
@bnevis-i bnevis-i deleted the issue-1435-2 branch July 19, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants