Adding gist github service

[jefcolbi]

Hi, i am trying to add gist github service but it is not working. This is what i tried

'github': {
              regex: /https?:\/\/gist.github.com\/([^\/\?\&]*)\/([^\/\?\&]*)/,
              embedUrl: 'https://gist.github.com/<%= remote_id %>',
              html: "<iframe height='300' scrolling='no' frameborder='no' allowtransparency='true' allowfullscreen='true' style='width: 100%;'></iframe>",
              height: 300,
              id: (groups) => groups.join('/')
          }

What am i doing wrong?

[rajeshbanoth]

Hi, i am trying to add gist github service but it is not working. This is what i tried

'github': {
              regex: /https?:\/\/gist.github.com\/([^\/\?\&]*)\/([^\/\?\&]*)/,
              embedUrl: 'https://gist.github.com/<%= remote_id %>',
              html: "<iframe height='300' scrolling='no' frameborder='no' allowtransparency='true' allowfullscreen='true' style='width: 100%;'></iframe>",
              height: 300,
              id: (groups) => groups.join('/')
          }

What am i doing wrong?

@jefcolbi if you could embedd GitHub gist please let me now I am also facing similar issue

[jefcolbi]

I have been able to add it yes

[rajeshbanoth]

I have been able to add it yes
@jefcolbi can you please share me the code I was unable to add git gist to editor

[jefcolbi]

@rajeshbanoth https://github.com/editor-js/embed/pull/91/files
#91

[neSpecc]

Still on review