Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github service #91

Merged
merged 8 commits into from
Oct 18, 2023
Merged

add github service #91

merged 8 commits into from
Oct 18, 2023

Conversation

jefcolbi
Copy link
Contributor

@jefcolbi jefcolbi commented Apr 25, 2022

This is the code required to add github gist service.

Resolves #82

Copy link
Contributor

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a test case for that update

@jefcolbi
Copy link
Contributor Author

@neSpecc hi. Please i am not a Javascript developer. i managed to have a friend help me for that. So for the test case i don't know what to do. You can be kind by writing a test case please.
Thanks

@reharis
Copy link
Contributor

reharis commented May 3, 2022

@jefcolbi @neSpecc
I have added tests, and applied some needed fixes. See this pen.
please see jefcolbi#1

tests added, and passing
@jefcolbi
Copy link
Contributor Author

jefcolbi commented May 3, 2022

@userharis i merged thanks.

@jefcolbi
Copy link
Contributor Author

Hi. Can this be merged? changes have been applied

@neSpecc neSpecc merged commit 05c392f into editor-js:master Oct 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding gist github service
3 participants