Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated bucket argument for recommended bucket_name #107

Merged
merged 1 commit into from
May 31, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented May 31, 2024

Description

The S3Boto3Storage backend no longer accepts the argument bucket. Use bucket_name or the setting AWS_STORAGE_BUCKET_NAME instead: jschneier/django-storages#636

This PR fixes this error in quince installations using django-storages 1.14:

  File "/openedx/edx-platform/./lms/envs/tutor/production.py", line 255, in scorm_xblock_storage
    return S3Boto3Storage(
  File "/openedx/venv/lib/python3.8/site-packages/storages/backends/s3.py", line 280, in __init__
    super().__init__(**settings)
  File "/openedx/venv/lib/python3.8/site-packages/storages/base.py", line 15, in __init__
    raise ImproperlyConfigured(
django.core.exceptions.ImproperlyConfigured: Invalid setting 'bucket' for S3Storage

The S3Boto3Storage backend no longer accepts the argument bucket. Use
bucket_name or the setting AWS_STORAGE_BUCKET_NAME instead:
jschneier/django-storages#636
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner May 31, 2024 20:06
@MoisesGSalas MoisesGSalas merged commit f21d338 into main May 31, 2024
4 checks passed
@MoisesGSalas MoisesGSalas deleted the MJG/django-storages-1.14-compatible branch May 31, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants