Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -warnaserror to dotnet restore #704

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Add -warnaserror to dotnet restore #704

merged 2 commits into from
Aug 8, 2023

Conversation

edumserrano
Copy link
Owner

@edumserrano edumserrano commented Aug 8, 2023 •
edited
Loading

Add -warnaserror to dotnet restore step.
Also restored tests for dotnet versions prior to 6.0.

Reasoning

On xunit 2.5.0 release, they've dropped support for anything older than dotnet 6.0. When dependabot updated the xunit packages on these projects, every workflow passed but the tests for dotnet core 3.1 and dotnet 5.0 were NOT being executed anymore.

When looking at the dotnet restore step we see warnings about the xunit packages:

/home/runner/work/dotnet-sdk-extensions/dotnet-sdk-extensions/tests/DotNet.Sdk.Extensions.Tests/DotNet.Sdk.Extensions.Tests.csproj : warning NU1701: Package 'xunit.runner.visualstudio 2.5.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [/home/runner/work/dotnet-sdk-extensions/dotnet-sdk-extensions/DotNet.Sdk.Extensions.sln]

/home/runner/work/dotnet-sdk-extensions/dotnet-sdk-extensions/tests/DotNet.Sdk.Extensions.Testing.Tests/DotNet.Sdk.Extensions.Testing.Tests.csproj : warning NU1701: Package 'xunit.runner.visualstudio 2.5.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [/home/runner/work/dotnet-sdk-extensions/dotnet-sdk-extensions/DotNet.Sdk.Extensions.sln]

These mean that the expected xunit package was not restored and then when running dotnet test no tests are found.

This PR would prevent this from happening because the workflow would fail at the dotnet restore step.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited
Loading

Test runs on ubuntu-latest for commit f9176d9

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v5.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:39:23 - 2023-08-08 11:39:28
Run Duration: 4s 454ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v5.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET 5.0.17) [xUnit.net 00:00:00.72]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.95]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.95]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:03.68]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v5.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:39:29 - 2023-08-08 11:39:40
Run Duration: 11s 776ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v5.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET 5.0.17) [xUnit.net 00:00:01.04]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:01.15]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:01.15]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:11.00]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:39:43 - 2023-08-08 11:39:51
Run Duration: 7s 594ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 6.0.20) [xUnit.net 00:00:00.35]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.05]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.06]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:04.58]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:39:52 - 2023-08-08 11:40:03
Run Duration: 11s 604ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 6.0.20) [xUnit.net 00:00:00.16]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.29]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.29]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:10.89]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:40:06 - 2023-08-08 11:40:10
Run Duration: 3s 735ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 7.0.9) [xUnit.net 00:00:00.21]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.50]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.51]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:03.09]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:40:11 - 2023-08-08 11:40:21
Run Duration: 10s 443ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 7.0.9) [xUnit.net 00:00:00.12]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.23]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:09.80]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v3.1 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:39:05 - 2023-08-08 11:39:08
Run Duration: 3s 766ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v3.1
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET Core 3.1.32) [xUnit.net 00:00:00.69]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.91]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.92]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.78]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v3.1 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:39:09 - 2023-08-08 11:39:21
Run Duration: 11s 255ms

GitHub Runner OS: ubuntu-latest
Operating System: Linux 5.15.0-1042-azure #49-Ubuntu SMP Tue Jul 11 17:28:46 UTC 2023
Framework: .NETCoreApp,Version=v3.1
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET Core 3.1.32) [xUnit.net 00:00:00.83]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.95]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.95]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:10.44]   Finished:    DotNet.Sdk.Extensions.Tests
----

@github-actions
Copy link

github-actions bot commented Aug 8, 2023 •
edited
Loading

Test runs on windows-latest for commit f9176d9

✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v5.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:33:47 - 2023-08-08 11:33:50
Run Duration: 2s 908ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v5.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET 5.0.17) [xUnit.net 00:00:00.54]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.69]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.69]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.39]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v5.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:33:51 - 2023-08-08 11:34:02
Run Duration: 10s 897ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v5.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET 5.0.17) [xUnit.net 00:00:00.52]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.59]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.60]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:10.41]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:34:04 - 2023-08-08 11:34:15
Run Duration: 11s 308ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 6.0.20) [xUnit.net 00:00:00.65]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.75]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.75]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:07.25]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v6.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:34:16 - 2023-08-08 11:34:27
Run Duration: 10s 986ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v6.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 6.0.20) [xUnit.net 00:00:00.16]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.24]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.24]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:10.51]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:34:29 - 2023-08-08 11:34:35
Run Duration: 5s 949ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 7.0.9) [xUnit.net 00:00:00.55]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.94]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:01.94]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:05.40]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v7.0 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:34:35 - 2023-08-08 11:34:47
Run Duration: 11s 628ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v7.0
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.5.0.1+5ebf84cd75 (64-bit .NET 7.0.9) [xUnit.net 00:00:00.26]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.33]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.34]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:11.21]   Finished:    DotNet.Sdk.Extensions.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Testing.Tests.dll on .NETCoreApp,Version=v3.1 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 149

Date: 2023-08-08 11:33:31 - 2023-08-08 11:33:34
Run Duration: 2s 960ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v3.1
Assembly: DotNet.Sdk.Extensions.Testing.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
149 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET Core 3.1.32) [xUnit.net 00:00:00.65]   Discovering: DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.79]   Discovered:  DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:00.79]   Starting:    DotNet.Sdk.Extensions.Testing.Tests [xUnit.net 00:00:02.34]   Finished:    DotNet.Sdk.Extensions.Testing.Tests
----
✔️ Pass - DotNet.Sdk.Extensions.Tests.dll on .NETCoreApp,Version=v3.1 ---- ## Run Summary

Overall Result: ✔️ Pass
Pass Rate: 100%
Total Tests: 157

Date: 2023-08-08 11:33:34 - 2023-08-08 11:33:45
Run Duration: 10s 932ms

GitHub Runner OS: windows-latest
Operating System: Microsoft Windows 10.0.20348
Framework: .NETCoreApp,Version=v3.1
Assembly: DotNet.Sdk.Extensions.Tests.dll

✔️ Passed ❌ Failed ⚠️ Skipped
157 0 0
100% 0% 0%
## Run Messages
Informational 
 [xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET Core 3.1.32) [xUnit.net 00:00:00.53]   Discovering: DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.60]   Discovered:  DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:00.60]   Starting:    DotNet.Sdk.Extensions.Tests [xUnit.net 00:00:10.43]   Finished:    DotNet.Sdk.Extensions.Tests
----

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #704 (f9176d9) into main (2a1a425) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
- Coverage   86.87%   86.79%   -0.08%     
==========================================
  Files          77       77              
  Lines        1409     1409              
  Branches      219      219              
==========================================
- Hits         1224     1223       -1     
  Misses        100      100              
- Partials       85       86       +1

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edumserrano edumserrano merged commit 105cf49 into main Aug 8, 2023
9 checks passed
@edumserrano edumserrano deleted the restore branch August 8, 2023 11:44
@edumserrano edumserrano mentioned this pull request Aug 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edumserrano