Fix broken tests #95
Fix broken tests #95
Conversation
While it is fairly easy to implement this functionality outside the library it is convenient to provide it with the other return values so it encapsulates everything needed on the pagination template on a single object. Although most template engines let you do the math on the template side there are some that don't or require writing extra helpers.
Add prev and next return values
|
Hmm, I see, lots of similar changes are in #73. I'm happy to help out getting all of this lot merged together, the changes are fairly simple but very important, since the current npm version (5.0.1) just flat out doesn't work. |
|
@fiznool do you plan on taking the reigns and supporting this repo? Just wondering if we can rely on updates out of your fork or whether we need to fork and maintain this ourselves? |
|
@rclayton-the-terrible I'm happy to maintain the codebase, at least for the time being, so it can be stabilised somewhat. |
|
@niftylettuce 👋 I know you were looking for somebody to help maintain the repo. I think this might be your person :) |
|
Awesome - @fiznool can you get this cleaned up, documented, and then ping me? niftylettuce@gmail.com - once you have a PR here ready to go - I will accept and give you NPM ownership. I don't have ability to give you ownership on here. Someone would need to contact GitHub and also relatives or friends for information regarding ownership in this scenario. |
I honestly don't know how anybody was using this plugin, it was so broken...
This PR fixes up the issues.