Drop type
property from all but Scalar nodes
#240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally,
type
was a thing that was carried into the AST nodes from the previous CST parser. Now, it's a clumsy & sometimes misleading API. So let's drop it elsewhere, but leave it for scalars where it still makes good sense. This is yet another BREAKING CHANGE.For scalars, let's move the constants from e.g.
Type.BLOCK_LITERAL
toScalar.BLOCK_LITERAL
. Otherwise, everything stays pretty much the same.For collections, we need to add a new
flow: boolean
property that can now be more easily set or toggled to control whether to use block or flow representation. As before withtype: 'FLOW_MAP' | 'FLOW_SEQ'
, settingflow: true
will force that choice for all of its child nodes as well.Dropping the
type
values also made it clear that Merge is no longer a good idea as a separate class; dropping it allows for merge nodes to be duck-typed whenmerge: true
orversion: '1.1'
is set.