Adding openroad gui to Makefile targets #273
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-m-bailey
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Looks good to me.
I copied the added code to a user_project and was able to run make gui and see the designs in the designs directory.
@marwaneltoukhy Do you have any comments?
|
May no longer be needed because the newest |
kareefardi
reviewed
Jun 18, 2023
| -e MCW_ROOT=$(MCW_ROOT) \ | ||
| --entrypoint "" \ | ||
| -v /tmp/.X11-unix:/tmp/.X11-unix -e DISPLAY=${DISPLAY} -h localhost -v $(HOME)/.Xauthority:$(HOME)/.Xauthority \ | ||
| -u $$(id -u $$USER):$$(id -g $$USER) efabless/openlane:latest \ |
There was a problem hiding this comment.
efabless/openlane:latest it should use OPENLANE_IMAGE_NAME and so this make target needs to be in ./openlane/Makefile
|
Furthermore, when update to latest OpenLane this PR wouldn't be needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.