Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cocotb tests #275

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Add cocotb tests #275

merged 4 commits into from
Jul 11, 2023

Conversation

M0stafaRady
Copy link
Member

Adding files needed for cocotb flow to run.
Added tests.

@marwaneltoukhy
Copy link
Member

marwaneltoukhy commented Jun 22, 2023

Is this going to replace the current flow? If so, can you remove everything that has to do with the current flow, especially from the documentation, and add the link on how to add cocotb tests in the quick start.

I have a few requests:

  1. Installation and run commands should be part of the quick start, even if it's in the readthedocs.
  2. I think you should release it on PyPi, to install it using pip not cloning and installing locally.
  3. Installation of cocotb infrastructure should be part of make setup.
  4. RTL and GL verification should run in the CI, just like the old setup.

If you need help with the last two point please let me know.

@jeffdi jeffdi merged commit 9e1a493 into main Jul 11, 2023
2 of 6 checks passed
@jeffdi jeffdi deleted the cocotb branch July 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants