Skip to content

Commit

Permalink
meta: remove redudant logging from dep updaters
Browse files Browse the repository at this point in the history
PR-URL: nodejs#53783
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
  • Loading branch information
RedYetiDev authored and ehsankhfr committed Jul 18, 2024
1 parent c10923c commit a29d45d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 25 deletions.
8 changes: 0 additions & 8 deletions tools/dep_updaters/update-acorn-walk.sh
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ tar -xf "$ACORN_WALK_TGZ"

mv package/* "$DEPS_DIR/acorn/acorn-walk"

echo "All done!"
echo ""
echo "Please git add acorn-walk, commit the new version:"
echo ""
echo "$ git add -A deps/acorn-walk"
echo "$ git commit -m \"deps: update acorn-walk to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down
9 changes: 0 additions & 9 deletions tools/dep_updaters/update-acorn.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,6 @@ cat > "$BASE_DIR/src/acorn_version.h" <<EOF
#endif // SRC_ACORN_VERSION_H_
EOF

echo "All done!"
echo ""
echo "Please git add acorn, commit the new version:"
echo ""
echo "$ git add -A deps/acorn/acorn"
echo "$ git add $BASE_DIR/src/acorn_version.h"
echo "$ git commit -m \"deps: update acorn to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down
8 changes: 0 additions & 8 deletions tools/dep_updaters/update-minimatch.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,6 @@ rm -rf node_modules

mv ./* "$DEPS_DIR/minimatch"

echo "All done!"
echo ""
echo "Please git add minimatch, commit the new version:"
echo ""
echo "$ git add -A deps/minimatch"
echo "$ git commit -m \"deps: update minimatch to $NEW_VERSION\""
echo ""

# Update the version number on maintaining-dependencies.md
# and print the new version as the last line of the script as we need
# to add it to $GITHUB_ENV variable
Expand Down

0 comments on commit a29d45d

Please sign in to comment.