Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libbeat cmds do not respect instance.Settings #10720

Closed
simitt opened this issue Feb 13, 2019 · 0 comments · Fixed by #10721
Closed

libbeat cmds do not respect instance.Settings #10720

simitt opened this issue Feb 13, 2019 · 0 comments · Fixed by #10721
Labels
bug v7.0.0

Comments

@simitt
Copy link
Contributor

simitt commented Feb 13, 2019

Several commands in libbeat/cmd do not respect instance.Settings, but only use dedicated attributes from it. This can lead to bugs for e.g. running export template etc.
The bug was originally found in elastic/apm-server#1922.

Ensure that the settings are passed on to all cmds and remove deprecated Init() .
simitt added a commit to simitt/beats that referenced this issue Feb 13, 2019
@simitt
Remove deprecated Init(), pass instance.Settings around.
5f8ee22 
Ensure settings from rootCmd are respected also when calling `export`
and `setup`.
fixes elastic#10720
@simitt simitt mentioned this issue Feb 13, 2019
Merged
simitt added a commit that referenced this issue Feb 14, 2019
@simitt
Remove deprecated Init(), pass instance.Settings around. (#10721)
d83bb4d 
* Remove deprecated Init(), pass instance.Settings around.

Ensure settings from rootCmd are respected also when calling `export`
and `setup`.

fixes #10720
simitt added a commit to simitt/beats that referenced this issue Feb 15, 2019
@simitt
Remove deprecated Init(), pass instance.Settings around. (elastic#10721)
cd4feea 
* Remove deprecated Init(), pass instance.Settings around.

Ensure settings from rootCmd are respected also when calling `export`
and `setup`.

fixes elastic#10720
simitt added a commit that referenced this issue Feb 15, 2019
@simitt
[7.0] Remove deprecated Init(), pass instance.Settings around. (#10721)…
e4d3db5 
… (#10759)

Remove deprecated Init(), pass instance.Settings around. (#10721)
Ensure settings from rootCmd are respected also when calling `export`
and `setup`.

fixes #10720
DStape pushed a commit to DStape/beats that referenced this issue Aug 20, 2019
@simitt
Remove deprecated Init(), pass instance.Settings around. (elastic#10721)
18e6f2c 
* Remove deprecated Init(), pass instance.Settings around.

Ensure settings from rootCmd are respected also when calling `export`
and `setup`.

fixes elastic#10720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated Init(), pass instance.Settings around. simitt/beats
1 participant
@simitt