Stop waiting for signals on closed outleters #11263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
review
Filebeat
Outleters can wait for the finalization of filebeat. If the outleter is closed the goroutine will be still running even if it has nothing to do, leaking goroutines. Stop the goroutine waiting to close on signal if the outleter has been already closed.
jsoriano
force-pushed
the
stop-close-on-signal-goroutine
branch
from
71b804f
to
581df59
Compare
ruflin
added
[zube]: In Progress
[zube]: In Review
and removed
[zube]: In Progress
labels
kvch
reviewed
Mar 18, 2019
kvch
reviewed
Mar 18, 2019
jsoriano
force-pushed
the
stop-close-on-signal-goroutine
branch
from
97f7877
to
5c01cc0
Compare
kvch
approved these changes
Mar 18, 2019
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 27, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 27, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Mar 27, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
exekias
pushed a commit
that referenced
this pull request
Apr 2, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
jsoriano
added a commit
that referenced
this pull request
Apr 17, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
jsoriano
added a commit
that referenced
this pull request
Apr 17, 2019
Outleters start a goroutine to handle the finalization of filebeat. If the outleter is closed by other means the goroutine will be kept running even if it has nothing to do, leaking goroutines. Stop this goroutine if the outleter is closed. (cherry picked from commit 57c9891)
jsoriano
added a commit
that referenced
this pull request
May 24, 2019
Follows the strategy used in #10850 to check for goroutine leaks on tests in some places related to the leaks investigated as part of #9302. Several things here: * New helper to reuse the goroutine checker, it also prints now the goroutines dump on failure. * Add goroutine checks for autodiscover tests * Add goroutine checks for CloseOnSignal and SubOutlet tests (they detect the issues solved by #11263) * Add goroutine checks for log input tests (they detect issues solved by #12125 and #12164)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outleters start a goroutine to handle the finalization of filebeat. If the
outleter is closed by other means the goroutine will be kept running
even if it has nothing to do, leaking goroutines.
Stop this goroutine if the outleter is closed.