Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #18887 to 7.8: Fix gob encoding of system/package struct data #19044

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

andrewkroh
Copy link
Member

Cherry-pick of PR #18887 to 7.8 branch. Original message:

What does this PR do?

The system/package dataset uses encoding/gob to encode and decode
the Package struct data that it persists. The struct was updated to contain
an error which is an interface type that's not serializable by default.

I have made the field unexpected so that it is ignored by encoding/gob.

Why is it important?

The Auditbeat system module was emitting errors at runtime.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

The system/package dataset uses encoding/gob to encode and decode
the Package struct data that it persists. The struct was updated to contain
an error which is an interface type that's not serializable by default.

I have made the field unexpected so that it is ignored by encoding/gob.

Fixes elastic#18536

(cherry picked from commit cf7b643)
@andrewkroh andrewkroh requested a review from a team as a code owner June 8, 2020 17:00
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 8, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19044 updated]

  • Start Time: 2020-06-09T14:03:37.708+0000

  • Duration: 35 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 197
Skipped 17
Total 214

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andrewkroh andrewkroh merged commit a0bd3bd into elastic:7.8 Jun 9, 2020
@andrewkroh andrewkroh deleted the backport_18887_7.8 branch January 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants