Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/netflow: record IPv6 src and dst addresses #29383

Merged
merged 2 commits into from
Dec 13, 2021
Merged

x-pack/filebeat/input/netflow: record IPv6 src and dst addresses #29383

merged 2 commits into from
Dec 13, 2021

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Dec 13, 2021

What does this PR do?

This change records IPv6 addresses in netflow records and ensures that addresses are unique.

Why is it important?

Currently IPv6 addresses are dropped from the records that contain them. See #19210.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Confirm sanity of altered test cases.

How to test this PR locally

mage -v test in github.com/elastic/beats/x-pack/filebeat and go test in github.com/elastic/beats/x-pack/filebeat/input/netflow.

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 13, 2021
@efd6 efd6 marked this pull request as ready for review December 13, 2021 03:42
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-13T03:42:31.973+0000

  • Duration: 97 min 13 sec

  • Commit: 5228ab7

Test stats 🧪

Test Results
Failed 0
Passed 2415
Skipped 152
Total 2567

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewkroh
andrewkroh approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit bc09710 into elastic:master Dec 13, 2021
@efd6 efd6 deleted the filebeat/ipv6 branch December 13, 2021 22:04
mergify bot pushed a commit that referenced this pull request Dec 13, 2021
@efd6
x-pack/filebeat/input/netflow: record IPv6 src and dst addresses (#29383
325305a 
)

(cherry picked from commit bc09710)
@mergify mergify bot mentioned this pull request Dec 13, 2021
Closed
@efd6 efd6 added 8.1-candidate backport-v8.0.0 Automated backport with mergify and removed 8.0-candidate backport-v8.1.0 Automated backport with mergify labels Dec 13, 2021
mergify bot pushed a commit that referenced this pull request Dec 13, 2021
@efd6
x-pack/filebeat/input/netflow: record IPv6 src and dst addresses (#29383
116be5b 
)

(cherry picked from commit bc09710)
@mergify mergify bot mentioned this pull request Dec 13, 2021
Merged
@efd6
Copy link
Contributor Author

efd6 commented Dec 13, 2021

@Mergifyio backport 8.0

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

backport 8.0

✅ Backports have been created

efd6 added a commit that referenced this pull request Dec 14, 2021
@mergify @efd6
x-pack/filebeat/input/netflow: record IPv6 src and dst addresses (#29383
d23110f 
) (#29412)

(cherry picked from commit bc09710)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
8.1-candidate backport-v8.0.0 Automated backport with mergify bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[filebeat][netflow] copy ipv6 addresses to ECS fields
3 participants
@efd6 @elasticmachine @andrewkroh