Enhance filter check in k8s event metricset #29470
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
botelastic
bot
added
the
needs_team
ChrsMark
added
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
|
This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
NOTE: |
mergify
bot
added
the
backport-skip
| @@ -108,8 +108,16 @@ func (m *MetricSet) Run(reporter mb.PushReporter) { | |||
| m.watcher.AddEventHandler(kubernetes.FilteringResourceEventHandler{ | |||
| FilterFunc: func(obj interface{}) bool { | |||
| eve := obj.(*kubernetes.Event) | |||
| // if fields are null they are decoded to `0001-01-01 00:00:00 +0000 UTC` | |||
| // so we need to check if they are valid first | |||
| lastTimestampValid := kubernetes.Time(&eve.LastTimestamp).Year() > 1 | |||
There was a problem hiding this comment.
There is also time.IsZero() which checks if the time is 0001-01-01 00:00:00 +0000 UTC
There was a problem hiding this comment.
Good catch, that's a better check :).
Signed-off-by: chrismark <chrismarkou92@gmail.com>
mergify
bot
removed
the
backport-skip
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
(cherry picked from commit 43ae3c9)
What does this PR do?
Enhance filter check in k8s event metricset by checking
eventTimefield iflastTimestampis not a valid one.Why is it important?
Based on research made on #28923
lastTimestampis possible to be null and hence we need to fallback to checkingeventTimein order to filter older events. If both fields are null we cannot apply filtering and hence theskip_older: falseshould be used.cc: @MichaelKatsoulis