-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only connect to Elasticsearch instances with the same version or newer #29683
Only connect to Elasticsearch instances with the same version or newer #29683
Conversation
This pull request does not have a backport label. Could you fix it @kvch? 🙏
NOTE: |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
@kvch Is my understanding correct that we can target this against 8.1 as 8.0 does not talk to previous major versions anyways? |
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
We target this against 8.1. In 8.0, if someone tries to connect to an older version, we just emit a warning: #29723 |
/test filebeat |
@nimarezainia Can we make sure this is also clearly shown in our compatibility matrix? @kvch Based on your comment, someone could run Beats 8.0 vs ES 7.13 and the user would get a warning. Do we agree that we don't support this? |
Yes and yes. |
Please confirm this does or does not impact Logstash as the PR only mentions connections to Elasticsearch |
The change only affects Elasticsearch. The only code change here is to the beats Elasticsearch client. |
What does this PR do?
This PR adds a new callback to all Elasticsearch connections to check if the version is at least the same as the Beat. The check can be disabled by setting the new option
output.elasticsearch.allow_older_versions
to true.Why is it important?
By restricting the Elasticsearch versions we can provide optimal experience.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
Closes #29264