-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{,x-pack/}winlogbeat: resurrect tests for event processing #31464
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4ee82b1
x-pack/winlogbeat: port forward semi-processed events for tests
efd6 04686dc
winlogbeat/eventlog: make sure metadata is available for enrichment o…
efd6 8039eaa
x-pack/winlogbeat/module/sysmon/test: golden file for sysmon-11-filed…
efd6 24da692
X-pack/winlogbeat/module: ignore opcode field on Windows 2022
efd6 7e5ec1b
defer event field filtering until value comparison
efd6 4089f31
add tracking issue for Windows 2022 opcode handling
efd6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
x-pack/winlogbeat/module/powershell/test/powershell_windows_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| // or more contributor license agreements. Licensed under the Elastic License; | ||
| // you may not use this file except in compliance with the Elastic License. | ||
|
|
||
| package test | ||
|
|
||
| import ( | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/elastic/beats/v7/x-pack/winlogbeat/module" | ||
| "github.com/elastic/go-sysinfo/providers/windows" | ||
|
|
||
| // Register required processors. | ||
| _ "github.com/elastic/beats/v7/libbeat/cmd/instance" | ||
| _ "github.com/elastic/beats/v7/libbeat/processors/timestamp" | ||
| ) | ||
|
|
||
| // Ignore these fields because they can be different on different versions | ||
| // of windows. | ||
| var ignoreFields = []string{ | ||
| "message", | ||
| } | ||
|
|
||
| func TestPowerShell(t *testing.T) { | ||
| // FIXME: We do not get opcode strings in the XML on Windows 2022, so ignore that | ||
| // field there. Only apply this to that platform to avoid regressions elsewhere. | ||
| // This means that golden values should be generated on a non-2022 version of | ||
| // Windows to ensure that this field is properly rendered. This is checked in | ||
| // the module.TestPipeline function. | ||
| // | ||
| // See https://github.com/elastic/beats/issues/31490 for tracking issue. | ||
| os, err := windows.OperatingSystem() | ||
| if err != nil { | ||
| t.Fatalf("failed to get operating system info: %v", err) | ||
| } | ||
| t.Logf("running tests on %s", os.Name) | ||
| if strings.Contains(os.Name, "2022") { | ||
| ignoreFields = append(ignoreFields, "winlog.opcode") | ||
| t.Log("ignoring winlog.opcode") | ||
| } | ||
|
|
||
| module.TestPipeline(t, "testdata/*.evtx", module.WithFieldFilter(ignoreFields)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth caching this in the
*winEventLog, but I'd like to do that after getting the testing done.