Add MacOS installer to packaging #7481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 30, 2018
dev-tools/mage/pkgtypes.go
Outdated
| @@ -762,3 +803,16 @@ func addFileToTar(ar *tar.Writer, baseDir string, pkgFile PackageFile) error { | |||
| return file.Close() | |||
| }) | |||
| } | |||
|
|
|||
| func PackageDMG(spec PackageSpec) error { | |||
There was a problem hiding this comment.
exported function PackageDMG should have comment or be unexported
houndci-bot
reviewed
Jun 30, 2018
dev-tools/mage/pkgtypes.go
Outdated
| @@ -762,3 +803,16 @@ func addFileToTar(ar *tar.Writer, baseDir string, pkgFile PackageFile) error { | |||
| return file.Close() | |||
| }) | |||
| } | |||
|
|
|||
| func PackageDMG(spec PackageSpec) error { | |||
There was a problem hiding this comment.
exported function PackageDMG should have comment or be unexported
andrewkroh
force-pushed
the
feature/osx-pkg-dmg
branch
from
c4c6276
to
6da50e5
Compare
|
I kicked off a build at https://beats-ci.elastic.co/job/elastic+beats+pull-request+package/38/console. This is with APPLE_SIGNING_ENABLED=false (default). I'll do another test later with that enabled. |
andrewkroh
force-pushed
the
feature/osx-pkg-dmg
branch
2 times, most recently
from
3b5dd90
to
0be8d48
Compare
|
andrewkroh
force-pushed
the
feature/osx-pkg-dmg
branch
2 times, most recently
from
a50795a
to
7818449
Compare
andrewkroh
added
review
and removed
in progress
adriansr
approved these changes
Jul 3, 2018
This adds the creation of a .dmg files when building packages on MacOS (the
build host must be darwin with XCode installed). The .dmg file contains an
installer (.pkg) and a rudimentary Uninstall.app. When code signing is enabled
every part of the .dmg is signed. This is the structure of the package.
- beat.dmg
- beat.pkg
- internal-beat.pkg
- BeatPrefPane.pkg
- Uninstall.app
The following environment variables control the code signing behavior.
- APPLE_SIGNING_ENABLED - Must be set to true to enable signing. Defaults to
false.
- APPLE_SIGNING_IDENTITY_INSTALLER - filter for selecting the signing identity
for installers. It's effectively used as
`security find-identity -v | grep $APPLE_SIGNING_IDENTITY_INSTALLER` to
select a single certificate.
- APPLE_SIGNING_IDENTITY_APP - filter for selecting the signing identity
for apps.
Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
andrewkroh
force-pushed
the
feature/osx-pkg-dmg
branch
from
7818449
to
76526b9
Compare
|
Rebased to resolve conflicts with the Filebeat modules fix. This should be good to go after the packaging job completes. Build: https://beats-ci.elastic.co/job/elastic+beats+pull-request+package/46/console |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the creation of a .dmg files when building packages on MacOS (the
build host must be darwin with XCode installed). The .dmg file contains an
installer (.pkg) and a rudimentary Uninstall.app. When code signing is enabled
every part of the .dmg is signed. This is the structure of the package.
The following environment variables control the code signing behavior.
false.
for installers. It's effectively used as
security find-identity -v | grep $APPLE_SIGNING_IDENTITY_INSTALLERtoselect a single certificate.
for apps.
Co-authored-by: Adrian Serrano @adriansr
Screenshots of the installed package: #6053 (comment)