Move filebeat/reader to libbeat/reader #8206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
LGTM, Can you add a small note to CHANGELOG-developer.asciidoc to mention the move of the files and make other developpers aware of theses useful packages.
I've looked at the failure on CI, one is the test recursive on windows and the other one is a successful test that fails to upload the log artifacts on GCP..
ph
approved these changes
Sep 4, 2018
|
Failing tests are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use it from journalbeat. Also, moving the package as we already agreed.