Add functionbeat to the build process #8639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 17, 2018
|
Are you going to rename beatless in the build process in a follow-up PR? |
|
@kvch yes in a follow-up PR once the big one is merged. |
|
I will fix the make check 😢 |
ph
force-pushed
the
fix/beatless-packages
branch
from
e08029a
to
f226be3
Compare
|
@tsg rebase + make check fixed, this make it a simple self contains commit to be applied to the feature branch. |
ph
force-pushed
the
fix/beatless-packages
branch
3 times, most recently
from
f5e2105
to
5d8e79d
Compare
following changes:
Use a custom packages.yml to only build some of the artifact.
Each distribution also include a linux binary to be run on AWS lambda
Some refactoring is done in the mage.go file to allow to specify a
specs file more easily.
Make sure that beatless is added to build/distributions/beatless
ph
force-pushed
the
fix/beatless-packages
branch
from
5d8e79d
to
250f36c
Compare
|
I think there is a small problems with make check, I've looked at the license and it should be correct. |
|
Found the issue, using make update at the root generate a fields.go with the wrong header but header is fine when you generate it inside the beatless directory. |
|
Fix the docs build issue. |
42 tasks
|
Can you print a listing of the final artifacts, so we can check they are complete? |
tsg
approved these changes
Oct 18, 2018
Then the macOs one for example: |
|
I will merge this |
ph
added a commit
that referenced
this pull request
Oct 24, 2018
* This add beatless/functionbeat to the build processes and do the
following changes:
Use a custom packages.yml to only build some of the artifact.
Each distribution also include a linux binary to be run on AWS lambda
Some refactoring is done in the mage.go file to allow to specify a
specs file more easily.
Make sure that beatless is added to build/distributions/beatless
* fix the issue with license on the fields.go
* Adding minimal docs to satisfy DTD requirements and not fail the build
ph
added a commit
that referenced
this pull request
Oct 24, 2018
* This add beatless/functionbeat to the build processes and do the
following changes:
Use a custom packages.yml to only build some of the artifact.
Each distribution also include a linux binary to be run on AWS lambda
Some refactoring is done in the mage.go file to allow to specify a
specs file more easily.
Make sure that beatless is added to build/distributions/beatless
* fix the issue with license on the fields.go
* Adding minimal docs to satisfy DTD requirements and not fail the build
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
* This add beatless/functionbeat to the build processes and do the
following changes:
Use a custom packages.yml to only build some of the artifact.
Each distribution also include a linux binary to be run on AWS lambda
Some refactoring is done in the mage.go file to allow to specify a
specs file more easily.
Make sure that beatless is added to build/distributions/beatless
* fix the issue with license on the fields.go
* Adding minimal docs to satisfy DTD requirements and not fail the build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add beatless/functionbeat to the build processes and do the
following changes:
specs file more easily.
Notes
Depends on #8485, interesting commit is e08029a