The 'export config' subcommand should display field reference instead of values #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
review
libbeat
needs_backport
ph
changed the title
tsg
reviewed
Oct 26, 2018
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
urso
suggested changes
Oct 29, 2018
libbeat/beat/config.go
Outdated
|
|
||
| // ConfigOpts returns ucfg config options with a resolver linked to the current keystore. | ||
| // TODO: Refactor to allow insert into the config option array without having to redefine everything | ||
| func ConfigOpts(store keystore.Keystore) []ucfg.Option { |
There was a problem hiding this comment.
Let's not have these in libbeat/beat package. This package is supposed to be mostly stable providing some minimal common API for beats developers (No bc breaking changes if possible). Items with "TODO" + "Refactoring" should not land here.
Also, let's not leak the ucfg package. Libbeat is supposed to hide/wrap ucfg package.
There was a problem hiding this comment.
What do you propose to do to make sure we actually correctly initialize the resolvers?
There was a problem hiding this comment.
Let me take a look at that we pass to libbeat.
|
rebase and waiting for CI. |
|
I've looked at the test suite, results and everything seems to be fine on all platforms minus windows. I think something is weird with this slave. I've logged into the windows slaves and saw the following: |
|
jenkins test this please |
values Change the behavior of the export config to not display the values from the keystore or the environment.
ph
added
v6.6.0
and removed
needs_backport
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 30, 2018
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 30, 2018
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 30, 2018
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 30, 2018
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
ph
added a commit
to ph/beats
that referenced
this pull request
Oct 30, 2018
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…d display field reference instead of values (elastic#8832) Cherry-pick of PR elastic#8769 to 6.4 branch. Original message: Change the behavior of the export config to not display the values from the keystore or the environment.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… of values (elastic#8769) (elastic#8817) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 53b688b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the behavior of the export config to not display the values from
the keystore or the environment.