Make functionbeat build process depends on linux/amd64 #8889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
:Packaging
needs_backport
Functionbeat packaging depends on a linux binary that will be send to the serverless platform, previously the magefile for the project did not express that dependencies. This was causing problem when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allow you to specific dependency when you define the cross build logic.
ph
force-pushed
the
fix/allow-to-define-dependency-on-other-platforms
branch
from
82c6de1
to
61d3cc3
Compare
|
@andrewkroh Update with your changes. |
andrewkroh
approved these changes
Nov 2, 2018
ph
added a commit
to ph/beats
that referenced
this pull request
Nov 2, 2018
Functionbeat packaging depends on a Linux binary that will be sent to the serverless platform, previously the magefile for the project did not express that dependency. This was causing problems when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allows you to specific dependency when you define the cross build logic. (cherry picked from commit e2d448e)
ph
added
v6.5.0
and removed
needs_backport
ph
added a commit
to ph/beats
that referenced
this pull request
Nov 2, 2018
Functionbeat packaging depends on a Linux binary that will be sent to the serverless platform, previously the magefile for the project did not express that dependency. This was causing problems when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allows you to specific dependency when you define the cross build logic. (cherry picked from commit e2d448e)
|
Should we set the platforms list to just |
|
@jsoriano it is required, since the CLI can be run on linux, windows and mac but the binary on the actual serverless provider is linux/amd64. |
|
Oh ok, I see, I was not thinking on the CLI, thanks! |
ph
added a commit
that referenced
this pull request
Nov 8, 2018
…linux/amd64 (#8904) Cherry-pick of PR #8889 to 6.x branch. Original message: Functionbeat packaging depends on a Linux binary that will be sent to the serverless platform, previously the magefile for the project did not express that dependency. This was causing problems when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allows you to specific dependency when you define the cross build logic.
ph
added a commit
that referenced
this pull request
Nov 15, 2018
Functionbeat packaging depends on a Linux binary that will be sent to the serverless platform, previously the magefile for the project did not express that dependency. This was causing problems when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allows you to specific dependency when you define the cross build logic. (cherry picked from commit e2d448e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#8903) Functionbeat packaging depends on a Linux binary that will be sent to the serverless platform, previously the magefile for the project did not express that dependency. This was causing problems when you were building the packages only for a specific platform. This commit fixes that problem by introducing `mage.WithPlatforms` this allows you to specific dependency when you define the cross build logic. (cherry picked from commit f71fc5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionbeat packaging depends on a Linux binary that will be sent to
the serverless platform, previously the magefile for the project did not express
that dependency. This was causing problems when you were building the
packages only for a specific platform. This commit fixes that problem by
introducing
mage.WithPlatformsthis allows you to specific dependencywhen you define the cross build logic.