Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host.name vs hostname, host.ip vs ip inconsistencies #62

Open
vbohata opened this issue Jul 31, 2018 · 9 comments
Open

host.name vs hostname, host.ip vs ip inconsistencies #62

vbohata opened this issue Jul 31, 2018 · 9 comments
Labels

Comments

@vbohata
Copy link

vbohata commented Jul 31, 2018

There are inconsistencies about host.name vs hostname, ip. vs host.ip naming. For example device.hostname, device.ip, host.name, url.host.name. Is there any reason for that?

@ruflin
Copy link
Member

ruflin commented Aug 2, 2018

Mainly for historical reason but I agree it's something we should cleanup up. Also ties into the discussion we have here #40 and here #51

@ruflin
Copy link
Member

ruflin commented Aug 10, 2018

I opened #74 to address the host.name issue. For ip I'm starting to think we should make it a top level field like message and device or host are just using it, so it could be in both objects.

@webmat webmat mentioned this issue Sep 18, 2018
26 tasks
webmat pushed a commit to webmat/ecs that referenced this issue Oct 22, 2018
@webmat
Copy link
Contributor

webmat commented Oct 22, 2018

Not sure if the question around IPs is still relevant here.

If not, then #141 finally addresses the host.name vs hostname question. We've decided to go with the industry convention of using hostname, even if there is repetition in one case (host.hostname). This will ensure it's consistent with all other places where we have hostname.

@vbohata
Copy link
Author

vbohata commented Oct 23, 2018

Industry convention usually allows hostname to contain IP if host name is unknown ... so it could mix with ip ...

@webmat
Copy link
Contributor

webmat commented Oct 23, 2018

Ah yeah if you don't have a hostname set for a device or host, you can totally cram an IP in there.

@webmat
Copy link
Contributor

webmat commented Oct 23, 2018

Note that to get the full use of indexing IP addresses properly, you would still want to save the host's IP(s) in the field host.ip, which is indexed with type ip.

Given the variety of possible values in a hostname, this field is indexed as keyword.

webmat pushed a commit to webmat/ecs that referenced this issue Oct 23, 2018
webmat pushed a commit to webmat/ecs that referenced this issue Oct 23, 2018
webmat pushed a commit to webmat/ecs that referenced this issue Oct 25, 2018
@webmat
Copy link
Contributor

webmat commented Oct 25, 2018

@vbohata Did this clarify things enough? Do you feel the documentation for host.hostname and device.hostname should be amended to mention this?

@jamiehynds
Copy link
Contributor

@ebeahan are we still planning on deprecating host.hostname in 8.0? If so can we close this issue?

@ebeahan
Copy link
Member

ebeahan commented Oct 29, 2021

@jamiehynds No, we're not deprecating host.hostname in 8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants