Rename url.href to url.original #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would keep the keyword indexing but rename the nested field to I think full text search on an original URL can be useful for ad hoc filtering on parts of the URL. So I would keep it around. |
ruflin
force-pushed
the
href-original
branch
2 times, most recently
from
a23730f
to
78ab805
Compare
|
@webmat Quite a few things changed since the initial PR. Could you have a look again? |
webmat
approved these changes
Oct 31, 2018
Recently we changed several fields which contain the initial original value to .original. `href` now follows the same example. There is an issue with original in the description as it is text by default and we have .raw. What is our recommended approach here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we changed several fields which contain the initial original value to .original.
hrefnow follows the same example.There is an issue with original in the description as it is text by default and we have .raw. What is our recommended approach here?