Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pasing labelling props to <canvas> element #1096

Closed
myasonik opened this issue Mar 30, 2021 · 1 comment · Fixed by #1121
Closed

Allow pasing labelling props to <canvas> element #1096

myasonik opened this issue Mar 30, 2021 · 1 comment · Fixed by #1121
Assignees
@rshen91
Labels
:accessibility Accessibility related issue bug Something isn't working released Issue released publicly

Comments

@myasonik
Copy link

Describe the bug

There is no way to set aria-label or aria-labelledby on a chart.

Notes on implementation

  • With the end goal being something akin to this demo, I'd recommend not consuming aria-* props directly because in the long-term we won't use many. Rather, I'd recommend using label and labelledby respectively. This, I hope, is both clear as a standalone prop name and hopefully hints at what their implementation might be/mean.
@myasonik myasonik added bug Something isn't working :accessibility Accessibility related issue labels Mar 30, 2021
@myasonik myasonik mentioned this issue Mar 30, 2021
Closed
@myasonik myasonik mentioned this issue Apr 6, 2021
Merged
1 task
@rshen91 rshen91 self-assigned this Apr 14, 2021
@rshen91 rshen91 mentioned this issue Apr 14, 2021
Merged
2 tasks
rshen91 added a commit that referenced this issue Apr 22, 2021
@rshen91 @markov00
feat(a11y): add label for screen readers (#1121)
920e585 
Fixes #1096 

BREAKING CHANGE: `description` prop in `<Settings/>` is renamed to `ariaDescription`

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
nickofthyme pushed a commit that referenced this issue Apr 22, 2021
@semantic-release-bot @markov00
chore(release): 29.0.0 [skip ci]
9ab72cc 
# [29.0.0](v28.2.0...v29.0.0) (2021-04-22)

### Features

* **a11y:** add label for screen readers ([#1121](#1121)) ([920e585](920e585)), closes [#1096](#1096)
* **annotations:** marker body with dynamic positioning ([#1116](#1116)) ([601abac](601abac))

### BREAKING CHANGES

* **a11y:** `description` prop in `<Settings/>` is renamed to `ariaDescription`

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 29.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 22, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot @markov00
chore(release): 29.0.0 [skip ci]
70e503a 
# [29.0.0](elastic/elastic-charts@v28.2.0...v29.0.0) (2021-04-22)

### Features

* **a11y:** add label for screen readers ([opensearch-project#1121](elastic/elastic-charts#1121)) ([ddb8782](elastic/elastic-charts@ddb8782)), closes [opensearch-project#1096](elastic/elastic-charts#1096)
* **annotations:** marker body with dynamic positioning ([#1116](elastic/elastic-charts#1116)) ([997d487](elastic/elastic-charts@997d487))

### BREAKING CHANGES

* **a11y:** `description` prop in `<Settings/>` is renamed to `ariaDescription`

Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rshen91 rshen91

Labels
:accessibility Accessibility related issue bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(a11y): add label for screen readers rshen91/elastic-charts
3 participants
@myasonik @nickofthyme @rshen91