Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush area is off by 1 cell #1229

Closed
markov00 opened this issue Jul 5, 2021 · 1 comment · Fixed by #1230
Closed

Brush area is off by 1 cell #1229

markov00 opened this issue Jul 5, 2021 · 1 comment · Fixed by #1230
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue regression released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Jul 5, 2021

Describe the bug
After some recent changes #1212 the heatmap brush on time x scale is off by 1 cell

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/heatmap-alpha--basic
  2. Try to drag and select a singe cell
  3. The selection will cover nothing or two cells minimum on the X axis

Expected behaviour
The brush should always be consistent with the dragged area

Screenshots

Jul-01-2021 10-32-55

Version (please complete the following information):

  • Elastic Charts: 31.0.0
@markov00 markov00 added bug Something isn't working regression :heatmap Heatmap/Swimlane chart related issue labels Jul 5, 2021
@markov00 markov00 mentioned this issue Jul 5, 2021
Merged
4 tasks
markov00 added a commit that referenced this issue Jul 6, 2021
@markov00
fix(heatmap): pick correct brush end value (#1230)
57678fe 
fix #1229
nickofthyme pushed a commit that referenced this issue Jul 6, 2021
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
f8a7111 
# [31.1.0](v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([#1230](#1230)) ([57678fe](57678fe)), closes [#1229](#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](#1174)) ([ffa8822](ffa8822)), closes [#1160](#1160)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 31.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jul 6, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 31.1.0 [skip ci]
ad6591f 
# [31.1.0](elastic/elastic-charts@v31.0.0...v31.1.0) (2021-07-06)

### Bug Fixes

* **heatmap:** pick correct brush end value ([opensearch-project#1230](elastic/elastic-charts#1230)) ([cb95a75](elastic/elastic-charts@cb95a75)), closes [opensearch-project#1229](elastic/elastic-charts#1229)

### Features

* **a11y:** accessible goal and gauge chart ([#1174](elastic/elastic-charts#1174)) ([775dc98](elastic/elastic-charts@775dc98)), closes [opensearch-project#1160](elastic/elastic-charts#1160)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working :heatmap Heatmap/Swimlane chart related issue regression released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(heatmap): pick correct brush end value markov00/elastic-charts
2 participants
@markov00 @nickofthyme