Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legend positioned inside the charts #861

Closed
timroes opened this issue Oct 8, 2020 · 1 comment · Fixed by #1031
Closed

Legend positioned inside the charts #861

timroes opened this issue Oct 8, 2020 · 1 comment · Fixed by #1031
Assignees
@markov00
Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue released Issue released publicly

Comments

@timroes
Copy link

timroes commented Oct 8, 2020 •
edited
Loading

To replace timelion's flot implementation in Kibana by elastic-chart we'd need to be able to place the legend inside the chart. After a quick chat with @markov00 we decided this might be good to be implemented inside elastic charts.

screenshot-20201008-100941

You currently have 4 positions for the legend inside charts in Timelion: northeast, northwest, southeast, southwest.

Kibana cross issue: elastic/kibana#79984
@timroes timroes added enhancement New feature or request :legend Legend related issue labels Oct 8, 2020
@timroes timroes mentioned this issue Oct 8, 2020
Closed
3 tasks
@timroes timroes added the kibana cross issue Has a Kibana issue counterpart label Oct 8, 2020
@markov00 markov00 mentioned this issue Oct 13, 2020
Closed
7 tasks
@markov00 markov00 mentioned this issue Feb 17, 2021
Merged
@markov00 markov00 mentioned this issue Feb 17, 2021
Closed
7 tasks
@markov00 markov00 self-assigned this Mar 3, 2021
markov00 added a commit that referenced this issue Mar 24, 2021
@markov00
feat(xy_charts): render legend inside the chart (#1031)
ba88122 
This commit adds the ability to display the legend inside the XY cartesian charts.
The <Settings> property legendPosition will take now an extended version of the position that allows increased customizability. The legend outside the chart only works with the following cases: `direction: vertical, vAlign: top, hAlign: left/right`, `direction: horizontal, hAlign:left, vAlign: top/bottom`,

fix #861
github-actions bot pushed a commit that referenced this issue Mar 26, 2021
@semantic-release-bot
chore(release): 26.1.0 [skip ci]
58e6b5f 
# [26.1.0](v26.0.0...v26.1.0) (2021-03-26)

### Features

* **a11y:** add basic aria-label to canvas element ([#1084](#1084)) ([1a5aef7](1a5aef7))
* **xy_charts:** render legend inside the chart ([#1031](#1031)) ([ba88122](ba88122)), closes [#861](#861)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 26.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Mar 26, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 26.1.0 [skip ci]
fd910a5 
# [26.1.0](elastic/elastic-charts@v26.0.0...v26.1.0) (2021-03-26)

### Features

* **a11y:** add basic aria-label to canvas element ([opensearch-project#1084](elastic/elastic-charts#1084)) ([d4b3e4f](elastic/elastic-charts@d4b3e4f))
* **xy_charts:** render legend inside the chart ([opensearch-project#1031](elastic/elastic-charts#1031)) ([b271d09](elastic/elastic-charts@b271d09)), closes [opensearch-project#861](elastic/elastic-charts#861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request kibana cross issue Has a Kibana issue counterpart :legend Legend related issue released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(xy_charts): render legend inside the chart markov00/elastic-charts
3 participants
@timroes @markov00 @nickofthyme