Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): series tick formatters #802

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Sep 4, 2020

Summary

Fix for elastic/kibana#74951.

Allow SeriesSpec to have tickFormat for different tooltip formatted values.

Set different axes formatter

Screen Recording 2020-09-03 at 09 39 PM

Axis formatter defaults to first series formatter

Screen Recording 2020-09-03 at 09 39 PM

Axis formatter defaults to default formatter with no series formatters

Screen Recording 2020-09-03 at 09 40 PM

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme marked this pull request as ready for review September 4, 2020 14:52
@monfera monfera self-requested a review September 4, 2020 16:15
Copy link
Contributor

@monfera monfera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks great, code kept simple, widespread tests!

@nickofthyme nickofthyme merged commit fbcd92e into elastic:master Sep 4, 2020
markov00 pushed a commit that referenced this pull request Sep 6, 2020
# [21.1.0](v21.0.1...v21.1.0) (2020-09-06)

### Bug Fixes

* **axis:** misaligned axis with rotated histogram bar charts ([#805](#805)) ([6c454e1](6c454e1))

### Features

* **brush:** histogram brushing last values and rounding ([#801](#801)) ([6d0319f](6d0319f))
* **tooltip:** series tick formatters ([#802](#802)) ([fbcd92e](fbcd92e))
@markov00
Copy link
Member

markov00 commented Sep 6, 2020

🎉 This PR is included in version 21.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 6, 2020
@nickofthyme nickofthyme added :tooltip Related to hover tooltip :xy Bar/Line/Area chart related enhancement New feature or request labels Sep 10, 2020
@nickofthyme nickofthyme deleted the feat/series-value-formatter branch January 25, 2021 15:13
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# [21.1.0](elastic/elastic-charts@v21.0.1...v21.1.0) (2020-09-06)

### Bug Fixes

* **axis:** misaligned axis with rotated histogram bar charts ([opensearch-project#805](elastic/elastic-charts#805)) ([a52a692](elastic/elastic-charts@a52a692))

### Features

* **brush:** histogram brushing last values and rounding ([opensearch-project#801](elastic/elastic-charts#801)) ([867abbc](elastic/elastic-charts@867abbc))
* **tooltip:** series tick formatters ([opensearch-project#802](elastic/elastic-charts#802)) ([813b915](elastic/elastic-charts@813b915))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released Issue released publicly :tooltip Related to hover tooltip :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants