Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose datum as part of GeometryValue #822

Merged
merged 9 commits into from
Sep 29, 2020
Merged

feat: expose datum as part of GeometryValue #822

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3cd97c3
feat: expose datum as part of GeometryValue
markov00 Sep 15, 2020
df57f08
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 15, 2020
77ef4d3
docs: update API check
markov00 Sep 16, 2020
18b6505
Merge branch '2020_09_15-expose_datum_to_geometryvalue' of github.com…
markov00 Sep 16, 2020
ff771b1
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 16, 2020
5702ab1
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 17, 2020
d6eb483
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 18, 2020
49aa618
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 24, 2020
f98e7df
Merge branch 'master' into 2020_09_15-expose_datum_to_geometryvalue
markov00 Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/charts.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,6 +646,8 @@ export interface GeometryValue {
// (undocumented)
accessor: BandedAccessorType;
// (undocumented)
datum: any;
// (undocumented)
mark: number | null;
// (undocumented)
x: any;
Expand Down
18 changes: 18 additions & 0 deletions src/chart_types/xy_chart/rendering/rendering.areas.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 10],
},
transform: {
x: 25,
Expand All @@ -199,6 +200,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 5,
mark: null,
datum: [1, 5],
},
transform: {
x: 25,
Expand Down Expand Up @@ -329,6 +331,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 10],
},
transform: {
x: 25,
Expand All @@ -353,6 +356,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 5,
mark: null,
datum: [1, 5],
},
transform: {
x: 25,
Expand Down Expand Up @@ -385,6 +389,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 20,
mark: null,
datum: [0, 20],
},
transform: {
x: 25,
Expand All @@ -409,6 +414,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 10,
mark: null,
datum: [1, 10],
},
transform: {
x: 25,
Expand Down Expand Up @@ -495,6 +501,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 10],
},
transform: {
x: 0,
Expand All @@ -519,6 +526,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 5,
mark: null,
datum: [1, 5],
},
transform: {
x: 0,
Expand Down Expand Up @@ -648,6 +656,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 10],
},
transform: {
x: 0,
Expand All @@ -672,6 +681,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 5,
mark: null,
datum: [1, 5],
},
transform: {
x: 0,
Expand Down Expand Up @@ -704,6 +714,7 @@ describe('Rendering points - areas', () => {
x: 0,
y: 20,
mark: null,
datum: [0, 20],
},
transform: {
x: 0,
Expand All @@ -728,6 +739,7 @@ describe('Rendering points - areas', () => {
x: 1,
y: 10,
mark: null,
datum: [1, 10],
},
transform: {
x: 0,
Expand Down Expand Up @@ -814,6 +826,7 @@ describe('Rendering points - areas', () => {
x: 1546300800000,
y: 10,
mark: null,
datum: [1546300800000, 10],
},
transform: {
x: 0,
Expand All @@ -838,6 +851,7 @@ describe('Rendering points - areas', () => {
x: 1546387200000,
y: 5,
mark: null,
datum: [1546387200000, 5],
},
transform: {
x: 0,
Expand Down Expand Up @@ -952,6 +966,7 @@ describe('Rendering points - areas', () => {
x: 1546300800000,
y: 10,
mark: null,
datum: [1546300800000, 10],
},
transform: {
x: 0,
Expand All @@ -976,6 +991,7 @@ describe('Rendering points - areas', () => {
x: 1546387200000,
y: 5,
mark: null,
datum: [1546387200000, 5],
},
transform: {
x: 0,
Expand Down Expand Up @@ -1008,6 +1024,7 @@ describe('Rendering points - areas', () => {
x: 1546300800000,
y: 20,
mark: null,
datum: [1546300800000, 20],
},
transform: {
x: 0,
Expand All @@ -1032,6 +1049,7 @@ describe('Rendering points - areas', () => {
x: 1546387200000,
y: 10,
mark: null,
datum: [1546387200000, 10],
},
transform: {
x: 0,
Expand Down
14 changes: 14 additions & 0 deletions src/chart_types/xy_chart/rendering/rendering.bands.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 2,
mark: null,
datum: [0, 2, 10],
},
transform: {
x: 25,
Expand All @@ -200,6 +201,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 2, 10],
},
transform: {
x: 25,
Expand All @@ -223,6 +225,7 @@ describe('Rendering bands - areas', () => {
x: 1,
y: 3,
mark: null,
datum: [1, 3, 5],
},
styleOverrides: undefined,
transform: {
Expand All @@ -248,6 +251,7 @@ describe('Rendering bands - areas', () => {
x: 1,
y: 5,
mark: null,
datum: [1, 3, 5],
},
transform: {
x: 25,
Expand Down Expand Up @@ -334,6 +338,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 2, 10],
},
transform: {
x: 25,
Expand All @@ -351,6 +356,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 2,
mark: null,
datum: [0, 2, 10],
},
}),
);
Expand All @@ -361,6 +367,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 2, 10],
},
}),
);
Expand All @@ -373,6 +380,7 @@ describe('Rendering bands - areas', () => {
x: 2,
y: 3,
mark: null,
datum: [2, 3, 5],
},
}),
);
Expand All @@ -385,6 +393,7 @@ describe('Rendering bands - areas', () => {
x: 2,
y: 5,
mark: null,
datum: [2, 3, 5],
},
}),
);
Expand All @@ -397,6 +406,7 @@ describe('Rendering bands - areas', () => {
x: 3,
y: 3,
mark: null,
datum: [3, 3, 5],
},
}),
);
Expand All @@ -409,6 +419,7 @@ describe('Rendering bands - areas', () => {
x: 3,
y: 5,
mark: null,
datum: [3, 3, 5],
},
}),
);
Expand Down Expand Up @@ -463,6 +474,7 @@ describe('Rendering bands - areas', () => {
x: 0,
y: 10,
mark: null,
datum: [0, 2, 10],
},
seriesIdentifier: {
specId: SPEC_ID,
Expand Down Expand Up @@ -502,6 +514,7 @@ describe('Rendering bands - areas', () => {
x: 2,
y: 5,
mark: null,
datum: [2, 3, 5],
},
seriesIdentifier: {
specId: SPEC_ID,
Expand Down Expand Up @@ -541,6 +554,7 @@ describe('Rendering bands - areas', () => {
x: 3,
y: 8,
mark: null,
datum: [3, 4, 8],
},
seriesIdentifier: {
specId: SPEC_ID,
Expand Down
Loading