[Serverless] Update role name description #2888
Draft
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've update the role name parameter description to point out the restrictions we have. But since the specification is generated from
SecurityPutRoleRequest.ts(and is shared), it makes this proposed change true for Serverless, but completely wrong for stateful.Also this change is fragile, anytime someone runs
make contribit will override the specs for stateful as well.It's not nice, but I could potentially word it in a way to mention that this restriction only applies in Serverless. LMKWYT?
Ideally, we should have this documented in the dedicated docs for Serverles.