Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search response types #2893

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fix search response types #2893

merged 2 commits into from
Sep 24, 2024

Conversation

pquentin
Copy link
Member

Most failures were related to vector search profiling:

The remaining failures are NEST tests.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2216/2280 2257/2262

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search 🔴 2217/2281 2257/2263

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with the java client

@pquentin pquentin merged commit 2bc7f44 into main Sep 24, 2024
6 checks passed
@pquentin pquentin deleted the search-response-types branch September 24, 2024 09:39
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit 2bc7f44)
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
Co-authored-by: Laura Trotta <153528055+l-trotta@users.noreply.github.com>
(cherry picked from commit 2bc7f44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants