Refactor aggregator test case #90149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-napoleon
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Sep 19, 2022
| MappedFieldType... fieldTypes) { | ||
| public AggTestConfig(IndexSearcher searcher, Query query, AggregationBuilder builder, MappedFieldType... fieldTypes) { | ||
| this(searcher, query, builder, DEFAULT_MAX_BUCKETS, randomBoolean(), fieldTypes); | ||
| } |
There was a problem hiding this comment.
I wonder if Query should default to MatchAllDocs. Otherwise, 👍
| * @param splitLeavesIntoSeparateAggregators If true this creates a new {@link Aggregator} | ||
| * for each leaf as though it were a separate index. If false this aggregates | ||
| * all leaves together, like we do in production. | ||
| * @param aggTestConfig |
nik9000
approved these changes
Sep 19, 2022
|
@elasticmachine update branch |
This was referenced Sep 20, 2022
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
searchAndReduceto use a parameter object, which removes a bunch of redundant overrides, and makes life much easier for adding new parameters in the future. I need that second part to add a parameter for testing caching over in #90114 so that the exactly two tests which are failing can tell the framework they don't actually expect to be cached.Yaks--;