Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid] Add sorting icon if the column is sorted #4343

Merged
merged 6 commits into from
Dec 8, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Dec 4, 2020

Summary

It adds a sorting indicator on the EuiDataGridColumn which renders only when the column is sorted and indicates the sorting direction.

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari and Firefox
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests

@stratoula stratoula changed the title [EuiDataGrid] Add sorting direction icon indicator if the column is s… [EuiDataGrid] Add sorting icon if the column is sorted Dec 4, 2020
@stratoula
Copy link
Contributor Author

I have used the sortUp and sortDown icons. I would appreciate a help here for design improvements.

@stratoula stratoula marked this pull request as ready for review December 4, 2020 09:30
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor PR to adjust some spacing. This is a nice PR with the appropriate tests.

I tested it extensively in browser in a couple scenarios. The truncation still works as I'd expect when the column is collapsed.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 from Discover side!

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

@snide
Copy link
Contributor

snide commented Dec 7, 2020

@stratoula Don't forget a changelog before you merge this.

@stratoula
Copy link
Contributor Author

@snide thank you, I def missed that 🙂

@cchaos

This comment has been minimized.

@cchaos
Copy link
Contributor

cchaos commented Dec 7, 2020

@stratoula disregard my last comment. Apparently it's more of a contentious change than I thought 😆

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

@snide
Copy link
Contributor

snide commented Dec 7, 2020

OK. @cchaos and I discussed. This is safe to merge as-is (upon @chandlerprall approval). We'll revisit the sorting arrows more generically in EUI (since tables use them) in a later PR.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4343/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM; tested various configurations in the PR's published docs.

Thanks for the test coverage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants