Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #118 to 7.x: Set agent active to false on unenroll #120

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #118 to 7.x branch. Original message:

What does this PR do?

Fixes issue where .fleet-agents active field is not set to false on un-enrollment. Without setting that field to false Kibana will still show the agent after successful un-enrollment.

Why is it important?

So unenroll action works correctly.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@blakerouse blakerouse self-assigned this Mar 3, 2021
Copy link
Member

@aleksmaus aleksmaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approve

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #120 opened

  • Start Time: 2021-03-03T21:16:09.378+0000

  • Duration: 10 min 58 sec

  • Commit: 0b6dc96

Test stats 🧪

Test Results
Failed 0
Passed 50
Skipped 0
Total 50

Trends 🧪

Image of Build Times

Image of Tests

@blakerouse blakerouse merged commit 0322984 into elastic:7.x Mar 3, 2021
@blakerouse blakerouse deleted the backport_118_7.x branch March 3, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants